Re: [PATCH v6 1/1] gpio: mpfs: add polarfire soc gpio support

[<Lewis.Hanly@xxxxxxxxxxxxx>]

On Thu, 2022-09-01 at 00:04 +0300, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Mon, Aug 22, 2022 at 2:30 PM Linus Walleij <
> linus.walleij@xxxxxxxxxx> wrote:
> > On Mon, Aug 15, 2022 at 2:08 PM <lewis.hanly@xxxxxxxxxxxxx> wrote:
> 
> ...
> 
> > This looks like  textbook example of a driver that can use
> > CONFIG_GPIO_GENERIC
> > See e.g. drivers/gpio/gpio-ftgpio010.c for an example
> > of how to use bgpio_init() to set up the helper library to handle
> > the GPIO side of things and combine it with an irqchip.
> > You get get/set_multiple() for free with this approach.
> > Also see documentation for bgpio_init() in
> > drivers/gpio/gpio-mmio.c.
> 
> I would also suggest looking at gpio-regmap.c.
Thanks Andy I will review the regmap.c file
> 
> --
> With Best Regards,
> Andy Shevchenko