Re: [PATCH 1/2] dt-bindings: gpio: pca9570: Add compatible for slg7xl45106

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 18/08/2022 12:30, Datta, Shubhrajyoti wrote:
> [AMD Official Use Only - General]
> 
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> Sent: Thursday, August 18, 2022 2:14 PM
>> To: Datta, Shubhrajyoti <shubhrajyoti.datta@xxxxxxx>; linux-
>> gpio@xxxxxxxxxxxxxxx
>> Cc: git-dev (AMD-Xilinx) <git-dev@xxxxxxx>; mans0n@xxxxxxxxxx;
>> devicetree@xxxxxxxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
>> robh+dt@xxxxxxxxxx; linus.walleij@xxxxxxxxxx; brgl@xxxxxxxx;
>> shubhrajyoti.datta@xxxxxxxxx
>> Subject: Re: [PATCH 1/2] dt-bindings: gpio: pca9570: Add compatible for
>> slg7xl45106
>>
>> [CAUTION: External Email]
>>
>> On 17/08/2022 11:55, Shubhrajyoti Datta wrote:
>>> This patch adds compatible string for the SLG7XL45106, I2C GPO
>>> expander.
>>>
>>> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxx>
>>> ---
>>>  Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
>>> b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
>>> index 338c5312a106..503cfcb7f7c9 100644
>>> --- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
>>> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
>>> @@ -13,6 +13,7 @@ properties:
>>>    compatible:
>>>      enum:
>>>        - nxp,pca9570
>>> +      - dlg,slg7xl45106
>>
>> First, this does not match tree, please rebase on some new Linux kernel.
>> Second, put them in alphabetical order.
>> Third, these are different manufacturers. Why do you think devices are
>> compatible?
> 
> Will rebase and resend.
> There was a earlier discussion
> https://lore.kernel.org/all/CAHp75Ve_mgam2jcyFG-NggziUScK3JBZ4fmtN+rjd+Vra=ixuw@xxxxxxxxxxxxxx/T/#me3fb70c782159b1c2aed9cc33d6eb4d31193e56e
> 
> Based on which I considered the pca.

But none of these are explained here in commit msg...

BTW, your previous binding was not even sent to DT mailing list and DT
maintainers. Always use scripts/get_maintainers.pl.

Best regards,
Krzysztof