Re: [PATCH 1/2] dt-bindings: gpio: pca9570: Add compatible for slg7xl45106

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 17/08/2022 11:55, Shubhrajyoti Datta wrote:
> This patch adds compatible string for the SLG7XL45106,
> I2C GPO expander.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxx>
> ---
>  Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> index 338c5312a106..503cfcb7f7c9 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> @@ -13,6 +13,7 @@ properties:
>    compatible:
>      enum:
>        - nxp,pca9570
> +      - dlg,slg7xl45106

First, this does not match tree, please rebase on some new Linux kernel.
Second, put them in alphabetical order.
Third, these are different manufacturers. Why do you think devices are
compatible?

Best regards,
Krzysztof