On Fri, Jun 17, 2022 at 7:20 AM Srinivas Neeli <srinivas.neeli@xxxxxxxxxx> wrote: > > In five different instances the return value of "of_property_read_u32" > API was neither captured nor checked. > > Fixed it by capturing the return value and then checking for any error. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@xxxxxxxxxx> > Addresses-Coverity: "check_return" I think the best course of action here is to go and fix Coverity while marking these as false positives. To the idea of castings -- this is not good style and (many?) maintainers in kernel do not accept such "workaround" for fixing broken tool. That said, NAK to the patch in any of its forms. -- With Best Regards, Andy Shevchenko
Re: [PATCH] gpio: gpio-xilinx: Check return value of of_property_read_u32
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] gpio: gpio-xilinx: Check return value of of_property_read_u32
- From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
- Date: Fri, 17 Jun 2022 18:02:00 +0200
- In-reply-to: <20220617051921.3801832-1-srinivas.neeli@xilinx.com>
- References: <20220617051921.3801832-1-srinivas.neeli@xilinx.com>
- Follow-Ups:
- Re: [PATCH] gpio: gpio-xilinx: Check return value of of_property_read_u32
- From: Michal Simek
- Re: [PATCH] gpio: gpio-xilinx: Check return value of of_property_read_u32
- References:
- [PATCH] gpio: gpio-xilinx: Check return value of of_property_read_u32
- From: Srinivas Neeli
- [PATCH] gpio: gpio-xilinx: Check return value of of_property_read_u32
- Prev by Date: Re: [PATCH v3 21/21] pinctrl: renesas: r8a779g0: add missing MODSELx for AVBx
- Next by Date: Re: [PATCH 10/10] pinctrl: Add AXP192 pin control driver
- Previous by thread: Re: [PATCH] gpio: gpio-xilinx: Check return value of of_property_read_u32
- Next by thread: Re: [PATCH] gpio: gpio-xilinx: Check return value of of_property_read_u32
- Index(es):
 |