Re: [PATCH v3 3/6] pinctrl: amd: Use PINCTRL_GRP to manage pingroups

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Tue, May 31, 2022 at 02:13:19PM +0530, Basavaraj Natikar wrote:
> AMD pingroup can be extended to support multi-function pins.
> Hence use PINCTRL_GRP to manage and represent larger number
> of pingroups inline.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
(with comments addressed in patch 1 and this one changed accordingly)

> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx>
> ---
>  drivers/pinctrl/pinctrl-amd.h | 36 ++++++-----------------------------
>  1 file changed, 6 insertions(+), 30 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-amd.h b/drivers/pinctrl/pinctrl-amd.h
> index 551dfa664ed8..d47217e7b39f 100644
> --- a/drivers/pinctrl/pinctrl-amd.h
> +++ b/drivers/pinctrl/pinctrl-amd.h
> @@ -291,36 +291,12 @@ static const unsigned uart0_pins[] = {135, 136, 137, 138, 139};
>  static const unsigned uart1_pins[] = {140, 141, 142, 143, 144};
>  
>  static const struct pingroup kerncz_groups[] = {
> -	{
> -		.name = "i2c0",
> -		.pins = i2c0_pins,
> -		.npins = 2,
> -	},
> -	{
> -		.name = "i2c1",
> -		.pins = i2c1_pins,
> -		.npins = 2,
> -	},
> -	{
> -		.name = "i2c2",
> -		.pins = i2c2_pins,
> -		.npins = 2,
> -	},
> -	{
> -		.name = "i2c3",
> -		.pins = i2c3_pins,
> -		.npins = 2,
> -	},
> -	{
> -		.name = "uart0",
> -		.pins = uart0_pins,
> -		.npins = 5,
> -	},
> -	{
> -		.name = "uart1",
> -		.pins = uart1_pins,
> -		.npins = 5,
> -	},
> +	PINCTRL_GRP("i2c0", i2c0_pins, 2),
> +	PINCTRL_GRP("i2c1", i2c1_pins, 2),
> +	PINCTRL_GRP("i2c2", i2c2_pins, 2),
> +	PINCTRL_GRP("i2c3", i2c3_pins, 2),
> +	PINCTRL_GRP("uart0", uart0_pins, 5),
> +	PINCTRL_GRP("uart1", uart1_pins, 5),
>  };
>  
>  #endif
> -- 
> 2.25.1
> 

-- 
With Best Regards,
Andy Shevchenko