Re: [PATCH v3 2/6] pinctrl: amd: Remove amd_pingroup and use pingroup

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Tue, May 31, 2022 at 02:13:18PM +0530, Basavaraj Natikar wrote:
> Remove 'struct amd_pingroup' and instead use 'struct pingroup'.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx>
> ---
>  drivers/pinctrl/pinctrl-amd.h | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-amd.h b/drivers/pinctrl/pinctrl-amd.h
> index 1d4317073654..551dfa664ed8 100644
> --- a/drivers/pinctrl/pinctrl-amd.h
> +++ b/drivers/pinctrl/pinctrl-amd.h
> @@ -74,12 +74,6 @@
>  
>  #define CLR_INTR_STAT	0x1UL
>  
> -struct amd_pingroup {
> -	const char *name;
> -	const unsigned *pins;
> -	unsigned npins;
> -};
> -
>  struct amd_function {
>  	const char *name;
>  	const char * const *groups;
> @@ -90,7 +84,7 @@ struct amd_gpio {
>  	raw_spinlock_t          lock;
>  	void __iomem            *base;
>  
> -	const struct amd_pingroup *groups;
> +	const struct pingroup *groups;
>  	u32 ngroups;
>  	struct pinctrl_dev *pctrl;
>  	struct gpio_chip        gc;
> @@ -296,7 +290,7 @@ static const unsigned i2c3_pins[] = {19, 20};
>  static const unsigned uart0_pins[] = {135, 136, 137, 138, 139};
>  static const unsigned uart1_pins[] = {140, 141, 142, 143, 144};
>  
> -static const struct amd_pingroup kerncz_groups[] = {
> +static const struct pingroup kerncz_groups[] = {
>  	{
>  		.name = "i2c0",
>  		.pins = i2c0_pins,
> -- 
> 2.25.1
> 

-- 
With Best Regards,
Andy Shevchenko