Hi Basavaraj, thanks for your patch! On Tue, May 24, 2022 at 9:40 AM Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx> wrote: > +#define PINCTRL_GRP(_name, _pins, _npins) \ > + { .name = _name, .pins = _pins, .npins = _npins} Please prefix this macro with AMD_ so it doesn't run the risk of namespace collisions with generic macros, AMD_PINCTRL_GRP(...). Yours, Linus Walleij