On Tue, Mar 29, 2022 at 09:59:32AM +0200, Fabien DESSENNE wrote: > On 25/03/2022 21:03, Andy Shevchenko wrote: Thanks for review, my answers below. > > - for_each_available_child_of_node(np, child) > > Here we look for "available" child, while the new generic helper > gpiochip_count() looks for any child, available or not. > Would it be possible to hav gpiochip_count() looking for available child as > well? It's done already that way. The fwnode loop is done against available children. > It looks like there is '_available_' version of > 'device_for_each_child_node', maybe this shall be added too. No need. -- With Best Regards, Andy Shevchenko