Re: [PATCH] dt-bindings: gpio: uniphier: Add hogs parsing

[Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>]

Hi Krzysztof,

On 2022/03/29 4:04, Krzysztof Kozlowski wrote:
> On 28/03/2022 03:28, Kunihiko Hayashi wrote:
> > Allow parsing GPIO controller children nodes with GPIO hogs to fix the
> > following warning:
> >
> >    uniphier-ld11-ref.dtb: gpio@55000000: 'xirq0-hog' does not match any of
> > the regexes: 'pinctrl-[0-9]+'
> >        From schema:
> > Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> >
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml  | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> > b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> > index bcafa494ed7a..b6f5963a2ae6 100644
> > --- a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> > +++ b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> > @@ -52,6 +52,13 @@ properties:
> >         <child-interrupt-base parent-interrupt-base length> triplets.
> >       $ref: /schemas/types.yaml#/definitions/uint32-matrix
> >
> > +patternProperties:
> > +  "^(.+-hog(-[0-9]+)?)$":
>
> The outer () are not needed.

Surely, the "()" can be removed.

> > +    type: object
>
> You need also properties. See for example:
> Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml

I see. I should list the valid properties in patternProperties.
I'll add it.

Thank you,

---
Best Regards
Kunihiko Hayashi