Re: [libgpiod v2][PATCH 4/6] line-config: rename num_values to num_lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 11, 2022 at 8:40 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
>
> Other functions, such as gpiod_line_request_set_values_subset()
> use num_lines to indicate the size of the set, so change
> num_values to num_lines in gpiod_line_config_set_output_values()
> to be consistent.
>
> Signed-off-by: Kent Gibson <warthog618@xxxxxxxxx>

This is the same issue as with patch 2. We're setting a number of
offset to value mappings (it's better visible in the C++ bindings
where we're actually setting std::pairs of offset -> value mapping. I
think that we need to pass is the number of values to set and not
number of lines. We are still preparing the configuration.

Bart



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux