On Fri, Mar 11, 2022 at 8:40 AM Kent Gibson <warthog618@xxxxxxxxx> wrote: > > Both gpiod_request_config and gpiod_line_request contain a number of > lines, but the former has a get_num_offsets accessor, while the latter > has get_num_lines. Make them consistent by switching request_config to > get_num_lines. > > Signed-off-by: Kent Gibson <warthog618@xxxxxxxxx> > --- IMO this doesn't make much sense because we still have gpiod_request_config_set_offsets(). So now you have set_offsets but get_lines. At the time of preparing the request_config we're still talking about offsets of lines to request, while once the request has been made, we're talking about requested lines. I would leave it as it is personally. Bart