Re: [PATCH] gpio: aggregator: Fix calling into sleeping GPIO controllers

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Tue, Feb 1, 2022 at 10:54 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Tue, Feb 1, 2022 at 9:35 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Tue, Feb 1, 2022 at 10:09 PM Geert Uytterhoeven
> > <geert+renesas@xxxxxxxxx> wrote:

...

> > > +       return chip->can_sleep ? gpiod_get_value_cansleep(fwd->descs[offset])
> > > +                              : gpiod_get_value(fwd->descs[offset]);
> >
> > This indentation kills the perfectionist in me :-)
>
> Why? The above is aligned perfectly ("?" just above ":")?
>
> > What about:
> >
> >        return chip->can_sleep ?
> >                gpiod_get_value_cansleep(fwd->descs[offset]) :
> > gpiod_get_value(fwd->descs[offset]);
> >
> > ?
> >
> > Or as variant
> >
> >        struct gpio_desc *desc = fwd->descs[offset];
> >
> >        return chip->can_sleep ? gpiod_get_value_cansleep(desc) :
> > gpiod_get_value(desc);
> >
> > ?
>
> IMHO, those are ugly as hell ;-)

I have the same opinion about your initial variant. :-)

So, up to the maintainer(s) what to do.

-- 
With Best Regards,
Andy Shevchenko