On Sun, Jan 30, 2022 at 08:47:23PM +0200, Andy Shevchenko wrote: > On Sat, Jan 29, 2022 at 4:10 PM kernel test robot <lkp@xxxxxxxxx> wrote: > > > > Hi "Jonathan, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on linusw-pinctrl/devel] > > [also build test WARNING on robh/for-next linus/master v5.17-rc1 next-20220128] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch] > > > > url: https://github.com/0day-ci/linux/commits/Jonathan-Neusch-fer/Nuvoton-WPCM450-pinctrl-and-GPIO-driver/20220129-195955 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel > > config: um-allmodconfig (https://download.01.org/0day-ci/archive/20220129/202201292234.NpSNe4TD-lkp@xxxxxxxxx/config) > > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > > reproduce (this is a W=1 build): > > # https://github.com/0day-ci/linux/commit/3fd91ea1bad905592e89c8f987f6bd3740329b80 > > git remote add linux-review https://github.com/0day-ci/linux > > git fetch --no-tags linux-review Jonathan-Neusch-fer/Nuvoton-WPCM450-pinctrl-and-GPIO-driver/20220129-195955 > > git checkout 3fd91ea1bad905592e89c8f987f6bd3740329b80 > > # save the config file to linux build tree > > mkdir build_dir > > make W=1 O=build_dir ARCH=um SHELL=/bin/bash drivers/pinctrl/nuvoton/ > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > > All warnings (new ones prefixed by >>): > > ... > > > >> drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c:908: warning: "DS" redefined > > 908 | #define DS(lo, hi) (((lo) << DRIVE_STRENGTH_LO_SHIFT) | \ > > | > > > arch/x86/um/shared/sysdep/ptrace_64.h:38: note: this is the location of the previous definition > > 38 | #define DS (HOST_DS * sizeof(long)) > > This is a good example why short and namespace-less definitions are > not always good even in standalone module. > > ... > > > drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c: In function 'npcm7xx_get_groups_count': > > drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c:1564:21: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=] > > Should be %zu > > If it's already in for-next, there should be two patches to fix these issues. These warnings are about the pinctrl-npcm7xx driver, which was merged many releases ago, but started to be built due to the Kconfig change in my patchset. I'll fix them anyway. Jonathan
Attachment:
signature.asc
Description: PGP signature
