Re: [PATCH] pinctrl: baytrail: Clear direct_irq_en flag on broken configs

[Hans de Goede <hdegoede@xxxxxxxxxx>]

Hi,

On 1/12/22 21:42, Andy Shevchenko wrote:
> On Wed, Jan 12, 2022 at 09:20:25PM +0100, Hans de Goede wrote:
>> On 1/8/22 10:59, Hans de Goede wrote:
>>> On 1/8/22 01:04, Andy Shevchenko wrote:
>>>> On Saturday, January 8, 2022, Hans de Goede <hdegoede@xxxxxxxxxx <mailto:hdegoede@xxxxxxxxxx>> wrote:
> 
> ...
> 
>>>>     byt_gpio INT33FC:02: Pin 0: uses direct IRQ 0 (APIC 67)
>>>>     byt_gpio INT33FC:02: Pin 15: uses direct IRQ 2 (APIC 69)
>>>>
>>>>
>>>> Should be these updated?
>>>
>>> Yes the " (APIC 6x)" part is gone now. I will fix this for v4.
>>>
>>>>     This is useful to figure out the GPIO pin belonging to ACPI
>>>>     resources like this one: "Interrupt () { 0x00000043 }" or
>>>>     the other way around.
>>>>
>>>>     Suggested-by: Andy Shevchenko <andy@xxxxxxxxxx <mailto:andy@xxxxxxxxxx>>
>>>>     Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx <mailto:hdegoede@xxxxxxxxxx>>
>>>>     ---
>>>>     Changes in v3:
>>>>     - Rework code to check if the pin is assigned one of the 16 direct IRQs
>>>>       (new code suggested-by Andy)
>>>>     - Drop dev_dbg of the (likely?) APIC IRQ, only log the direct IRQ index
>>>>
>>>>
>>>> Thinking about direct IRQ mappings I will look into the Datasheet next week.
>>>
>>> Ok, I will wait for you to get back to me then before posting a v4.
>>
>> Note I've found the direct IRQ to IO-APIC pin mappings now, they are
>> described in: atom-e3800-family-datasheet.pdf, so I've re-added
>> the APIC IRQ to the printed log msg for v4.
> 
> You mean below?
> 
> The 16 GPSCORE direct IRQs are mapped to IOAPIC_IRQ [66:51].
> The 16 GPSSUS direct IRQs are mapped to IOAPIC_IRQ [82:67].

Yes.

Regards,

Hans