RE: [PATCH] gpio Add my driver new id

[Richard Hsu(許育彰) <Richard_Hsu@xxxxxxxxxxxxxx>]

Hi Andy & Bartosz!
    Sorry for the late reply. New acpi device AMDIF031 have 24 gpio pins and older AMDF030/AMDIF030 have 8 gpio pins, 
I use acpi_bus_get_device() that check acpi device and gain acpi_dev info to replace the original. Then we check and compare device name from acpi_dev_name(acpi_dev).
If AMDIF031(pt_gpio->gc.ngpio = 24) or AMDF030/AMDIF030 (pt_gpio->gc.ngpio = 8).

I will try to use .driver_data, and add commit messages on title and code that explain what the code does in detail later

Thanks
     Richard
   
     > >  #define PT_TOTAL_GPIO 8
> > +#define PT_TOTAL_GPIO_EX 24

...

> > +       struct acpi_device *acpi_dev;
> > +       acpi_handle handle = ACPI_HANDLE(dev);

> > -       if (!ACPI_COMPANION(dev)) {
> > +       if (acpi_bus_get_device(handle, &acpi_dev)) {

What you are doing here is open coding the ACPI_COMPANION().
But see below.
...

> > +       if (!strncmp(acpi_dev_name(acpi_dev), "AMDIF031", 8))
> > +               pt_gpio->gc.ngpio = PT_TOTAL_GPIO_EX;
> > +       else
> > +               pt_gpio->gc.ngpio = PT_TOTAL_GPIO;

Instead of doing this...


> >  static const struct acpi_device_id pt_gpio_acpi_match[] = {
> >         { "AMDF030", 0 },
> >         { "AMDIF030", 0 },
> > +       { "AMDIF031", 0 },


-----Original Message-----
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> 
Sent: Saturday, December 4, 2021 5:21 AM
To: Bartosz Golaszewski <brgl@xxxxxxxx>
Cc: Richard Hsu <saraon640529@xxxxxxxxx>; Linus Walleij <linus.walleij@xxxxxxxxxx>; Richard Hsu(許育彰) <Richard_Hsu@xxxxxxxxxxxxxx>; open list:GPIO SUBSYSTEM <linux-gpio@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; Yd Tseng(曾裕達) <Yd_Tseng@xxxxxxxxxxxxxx>; Cindy1 Hsu(許凱茵) <Cindy1_Hsu@xxxxxxxxxxxxxx>; Andrew Su(蘇俊源) <Andrew_Su@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] gpio Add my driver new id

On Fri, Dec 03, 2021 at 11:15:46AM +0100, Bartosz Golaszewski wrote:
> On Fri, Dec 3, 2021 at 10:26 AM Richard Hsu <saraon640529@xxxxxxxxx> wrote:

Thanks, Bart, for pointing out to this.

> >  #define PT_TOTAL_GPIO 8
> > +#define PT_TOTAL_GPIO_EX 24

...

> > +       struct acpi_device *acpi_dev;
> > +       acpi_handle handle = ACPI_HANDLE(dev);

> > -       if (!ACPI_COMPANION(dev)) {
> > +       if (acpi_bus_get_device(handle, &acpi_dev)) {

What you are doing here is open coding the ACPI_COMPANION().
But see below.

...

> > +       if (!strncmp(acpi_dev_name(acpi_dev), "AMDIF031", 8))
> > +               pt_gpio->gc.ngpio = PT_TOTAL_GPIO_EX;
> > +       else
> > +               pt_gpio->gc.ngpio = PT_TOTAL_GPIO;

Instead of doing this...

> >  static const struct acpi_device_id pt_gpio_acpi_match[] = {
> >         { "AMDF030", 0 },
> >         { "AMDIF030", 0 },
> > +       { "AMDIF031", 0 },

Just use .driver_data here and if needed in the other ID tables and then simply retrieve it (w/o any conditions) in the code above:

	pt_gpio->gc.ngpio = (uintptr_t)device_get_match_data(dev);

> >         { },
> >  };

> Please Cc Andy next time on any GPIO stuff related to ACPI. I'll let 
> him comment on the code. Your commit message must be more descriptive
> - the title should say "gpio: <driver name>: <do this and that>".
> Please also add a commit message explaining what the code does in 
> detail.

--
With Best Regards,
Andy Shevchenko


<p></p>