Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade
From: Mauri Sandberg <maukka@xxxxxxxxxxxx>
Date: Fri, 15 Oct 2021 15:56:23 +0300
In-reply-to: <CAHp75VcjGpveAHNAW7Xf7d_Zf6LGSSyD6+qBiF9xxvb+EKs3tg@mail.gmail.com>
References: <20210325122832.119147-1-sandberg@mailfence.com> <20210621172053.107045-1-maukka@ext.kapsi.fi> <20210621172053.107045-3-maukka@ext.kapsi.fi> <CAHp75VcjGpveAHNAW7Xf7d_Zf6LGSSyD6+qBiF9xxvb+EKs3tg@mail.gmail.com>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0


On 21.6.2021 20.43, Andy Shevchenko wrote:

+       gc->of_node = np;


This should be guarded by CONFIG_OF_GPIO.

In the Kconfig I have a dependency to OF_GPIO. Is the guarding stillnecessary? Or should the guard be added and dependency removed? Or havethem both?

Follow-Ups:
- Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade
  - From: Andy Shevchenko

References:
- [RFC gpio/for-next 0/2] gpio: add generic gpio input multiplexer
  - From: Mauri Sandberg
- [PATCH v5 0/2] gpio: add generic gpio cascade
  - From: Mauri Sandberg
- [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade
  - From: Mauri Sandberg
- Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade
  - From: Andy Shevchenko

Prev by Date: [GIT PULL] pinctrl: renesas: Updates for v5.16 (take two)
Next by Date: [PATCH v4 0/2] pinctrl: pinctrl-microchip-sgpio: Extend to call reset driver
Previous by thread: Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade
Next by thread: Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade
Index(es):
- Date
- Thread

[Index of Archives] [Linux SPI] [Linux Kernel] [Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [Linux for Samsung SOC] [eCos] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [Linux MIPS] [Yosemite Campsites]