On Wed, Sep 22, 2021 at 12:30 AM Joey Gouly <joey.gouly@xxxxxxx> wrote: > I left two defines at the top 'USE_PINMUX_GENERIC_FN' and > 'USE_PINCTRL_GENERIC_FN', I wasn't sure if I should use the generic functions for > getting the groups/functions, so I left both approaches in and will remove one > of them for the next version! Which approach should I use? I think you should go with generic as far as possible, it usually gives less code to maintain. Yours, Linus Walleij