On Wed, Sep 22, 2021 at 3:09 PM Marc Zyngier <maz@xxxxxxxxxx> wrote: > Joey Gouly <joey.gouly@xxxxxxx> wrote: > > + pctl->irq_chip.name = dev_name(pctl->dev); > > No, please. We don't need a massively long name that will make > /proc/interrupts more messy than it needs to be (and creates ABI > issues when someone repaints the DT). Just say "GPIO". There may be some GPIO expanders in some systems as well so I'd use "APPLE-GPIO" or similar so we know it is the one on the SoC. Yours, Linus Walleij