Re: [PATCH] gpiolib: cdev: zero padding during conversion to gpioline_info_changed

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Sat, Jun 19, 2021 at 8:49 PM Gabriel Knezek
<gabeknez@xxxxxxxxxxxxxxxxxxx> wrote:
> On Sat, Jun 19, 2021 at 12:11:44PM +0800, Kent Gibson wrote:
> > On Fri, Jun 18, 2021 at 03:45:11PM -0700, Gabriel Knezek wrote:
> >
> > Probably should've been [PATCH v2], despite the subject rename.
> >
> > And CC the maintainers (LinusW and Bart here) and past reviewers (Andy
> > and me).
> Sorry about that. When sending the revised patch, should I change it to v2?
> Or perhaps v3?

Yes, v3 with a changelog for each previous version.

...

> > > From: Gabriel Knezek <gabeknez@xxxxxxxxxxxxx>
> > >
> >
> > A second From: header?  With a different address?
> > Perhaps you could pick one?
> > Neither git nor checkpatch.pl seem to mind, but it is odd.
>
> Apologies for that as well. git send-email doesn't play well with Exchange, so
> after talking to coworkers it turns out we have a separate email server for
> sending patches which I wasn't aware of before I sent the first one. :-/ Sorry
> for the confusion; I'll stick to the @linux address.

Don't forget to configure your Git accordingly (globally or per this project).
Note, you always can test this by doing

  git send-email --suppress-cc=all --to "Your Second <email@address>"

or so.

> > > Signed-off-by: Gabriel Knezek <gabeknez@xxxxxxxxxxxxx>
> >
> > You should retain the Fixes tag from v1 - it is important to identify
> > where this patch will need to be backported to.
> > And include at least the first twelve characters of the SHA-1 [1].
>
> Oh shoot. Sorry about that as well. I need to make a checklist.

The checklist is already made for you:
https://www.kernel.org/doc/html/latest/process/submit-checklist.html

> Thanks for the link; I did read it before submitting the second patch,
> but I clearly missed that part.
>
> > Still good with this bit ;)

> Thanks for the kind help. I promise I'll update our wiki with these
> learnings so hopefully dealing with the next person from our team submitting
> a patch won't be so painful.


-- 
With Best Regards,
Andy Shevchenko