On Sat, May 15, 2021 at 12:58 PM Alexandru Ardelean <aardelean@xxxxxxxxxxx> wrote: > > The platform_set_drvdata() call is only useful if we need to retrieve back > the private information. > Since the driver doesn't do that, it's not useful to have it. > > If this is removed, we can also just do a direct return on > devm_gpiochip_add_data(). We don't need to print that this call failed as > there are other ways to log/see this during probe. > > Signed-off-by: Alexandru Ardelean <aardelean@xxxxxxxxxxx> > --- > drivers/gpio/gpio-tc3589x.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c > index 55b8dbd13d11..8d158492488f 100644 > --- a/drivers/gpio/gpio-tc3589x.c > +++ b/drivers/gpio/gpio-tc3589x.c > @@ -357,16 +357,7 @@ static int tc3589x_gpio_probe(struct platform_device *pdev) > return ret; > } > > - ret = devm_gpiochip_add_data(&pdev->dev, &tc3589x_gpio->chip, > - tc3589x_gpio); > - if (ret) { > - dev_err(&pdev->dev, "unable to add gpiochip: %d\n", ret); > - return ret; > - } > - > - platform_set_drvdata(pdev, tc3589x_gpio); > - > - return 0; > + return devm_gpiochip_add_data(&pdev->dev, &tc3589x_gpio->chip, tc3589x_gpio); > } > > static struct platform_driver tc3589x_gpio_driver = { > -- > 2.31.1 > Applied, thanks! Bart