Re: [PATCH -next v2] gpio: GPIO_SCH: depends on LPC_SCH

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Fri, Apr 02, 2021 at 07:38:41PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 2, 2021 at 7:18 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> >
> > Since LPC_SCH provides GPIO functionality, GPIO_SCH should depend on
> > LPC_SCH to prevent kconfig warning and build errors:
> >
> > WARNING: unmet direct dependencies detected for LPC_SCH
> >   Depends on [n]: HAS_IOMEM [=y] && PCI [=n]
> >   Selected by [y]:
> >   - GPIO_SCH [=y] && GPIOLIB [=y] && X86 [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
> >
> > and
> >
> > ../drivers/mfd/lpc_sch.c:204:1: warning: data definition has no type or storage class
> >  module_pci_driver(lpc_sch_driver);
> >  ^~~~~~~~~~~~~~~~~
> > ../drivers/mfd/lpc_sch.c:204:1: error: type defaults to ‘int’ in declaration of ‘module_pci_driver’ [-Werror=implicit-int]
> > ../drivers/mfd/lpc_sch.c:204:1: warning: parameter names (without types) in function declaration
> > ../drivers/mfd/lpc_sch.c:197:26: warning: ‘lpc_sch_driver’ defined but not used [-Wunused-variable]
> >  static struct pci_driver lpc_sch_driver = {
> >                           ^~~~~~~~~~~~~~
> 
> Thanks!
> 
> Bart, please, take it in your tree directly, or if you wish I may
> collect this one together with Hans' one and send a PR.

Bart, nevermind. Same answer as to Hans' patch: I'll take care as usual.

-- 
With Best Regards,
Andy Shevchenko