Re: [PATCH -next v2] gpio: GPIO_SCH: depends on LPC_SCH

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Fri, Apr 2, 2021 at 7:18 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> Since LPC_SCH provides GPIO functionality, GPIO_SCH should depend on
> LPC_SCH to prevent kconfig warning and build errors:
>
> WARNING: unmet direct dependencies detected for LPC_SCH
>   Depends on [n]: HAS_IOMEM [=y] && PCI [=n]
>   Selected by [y]:
>   - GPIO_SCH [=y] && GPIOLIB [=y] && X86 [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
>
> and
>
> ../drivers/mfd/lpc_sch.c:204:1: warning: data definition has no type or storage class
>  module_pci_driver(lpc_sch_driver);
>  ^~~~~~~~~~~~~~~~~
> ../drivers/mfd/lpc_sch.c:204:1: error: type defaults to ‘int’ in declaration of ‘module_pci_driver’ [-Werror=implicit-int]
> ../drivers/mfd/lpc_sch.c:204:1: warning: parameter names (without types) in function declaration
> ../drivers/mfd/lpc_sch.c:197:26: warning: ‘lpc_sch_driver’ defined but not used [-Wunused-variable]
>  static struct pci_driver lpc_sch_driver = {
>                           ^~~~~~~~~~~~~~

Thanks!

Bart, please, take it in your tree directly, or if you wish I may
collect this one together with Hans' one and send a PR.

> Fixes: 6c46215d6b62 ("gpio: sch: Hook into ACPI GPE handler to catch GPIO edge events")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Cc: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> Cc: Denis Turischev <denis@xxxxxxxxxxxxxx>
> ---
> v2: change to "depends on LPC_SCH" as suggested by Andy
>
>  drivers/gpio/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210401.orig/drivers/gpio/Kconfig
> +++ linux-next-20210401/drivers/gpio/Kconfig
> @@ -861,9 +861,9 @@ config GPIO_IT87
>  config GPIO_SCH
>         tristate "Intel SCH/TunnelCreek/Centerton/Quark X1000 GPIO"
>         depends on (X86 || COMPILE_TEST) && ACPI
> +       depends on LPC_SCH
>         select GPIOLIB_IRQCHIP
>         select MFD_CORE
> -       select LPC_SCH
>         help
>           Say yes here to support GPIO interface on Intel Poulsbo SCH,
>           Intel Tunnel Creek processor, Intel Centerton processor or



-- 
With Best Regards,
Andy Shevchenko