RE: [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags

[David Laight <David.Laight@xxxxxxxxxx>]

From: Bartosz Golaszewski
> Sent: 15 March 2021 09:14
> 
> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> 
> For better readability and maintenance: use the (1UL << bit) for flag
> definitions.

If the values ever get printed in hex the hex definitions are
actually more useful.

	David

...
> -#define CONFIGFS_ROOT		0x0001
> -#define CONFIGFS_DIR		0x0002
> -#define CONFIGFS_ITEM_ATTR	0x0004
> -#define CONFIGFS_ITEM_BIN_ATTR	0x0008
> -#define CONFIGFS_ITEM_LINK	0x0020
> -#define CONFIGFS_USET_DIR	0x0040
> -#define CONFIGFS_USET_DEFAULT	0x0080
> -#define CONFIGFS_USET_DROPPING	0x0100
> -#define CONFIGFS_USET_IN_MKDIR	0x0200
> -#define CONFIGFS_USET_CREATING	0x0400
> +#define CONFIGFS_ROOT			(1UL << 0)
> +#define CONFIGFS_DIR			(1UL << 1)
> +#define CONFIGFS_ITEM_ATTR		(1UL << 2)
> +#define CONFIGFS_ITEM_BIN_ATTR		(1UL << 3)
> +#define CONFIGFS_ITEM_LINK		(1UL << 5)
> +#define CONFIGFS_USET_DIR		(1UL << 6)
> +#define CONFIGFS_USET_DEFAULT		(1UL << 7)
> +#define CONFIGFS_USET_DROPPING		(1UL << 8)
> +#define CONFIGFS_USET_IN_MKDIR		(1UL << 9)
> +#define CONFIGFS_USET_CREATING		(1UL << 10)
>  #define CONFIGFS_NOT_PINNED	(CONFIGFS_ITEM_ATTR | CONFIGFS_ITEM_BIN_ATTR)
> 
>  extern struct mutex configfs_symlink_mutex;
> --
> 2.30.1

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)