Re: [PATCH v2] gpio: regmap: set gpio_chip of_node

[Álvaro Fernández Rojas <noltari@xxxxxxxxx>]

Hi Andy,

> El 4 mar 2021, a las 16:22, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> escribió:
> 
> On Thu, Mar 4, 2021 at 5:18 PM Álvaro Fernández Rojas <noltari@xxxxxxxxx> wrote:
>> 
>> This is needed for properly registering gpio regmap as a child of a regmap
>> pin controller.
> 
>> +       chip->of_node = config->of_node ?: dev_of_node(config->parent);
> 
> After a closer look I have no clue why you need this patch at all.
> The second part, i.e. assigning parent's fwnode, is done already in
> the GPIO library core.
> The first part, keeping fwnode in the regmap configuration puzzles me. Why?

I’ve flagged this as superseded since Linus asked me to send it with bcm63xx patches and I’ve already answered this same question there.

> 
> -- 
> With Best Regards,
> Andy Shevchenko

Best regards,
Álvaro.