Re: [PATCH v1 0/3] Support building gpio-tegra driver as loadable module

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Sun, Jan 24, 2021 at 12:56 AM Dmitry Osipenko <digetx@xxxxxxxxx> wrote:
> 24.01.2021 01:50, Linus Walleij пишет:
> > On Fri, Jan 22, 2021 at 7:59 PM Dmitry Osipenko <digetx@xxxxxxxxx> wrote:
> >
> >> This small series adds modularization support to the gpio-tegra driver,
> >> i.e. driver now could be built as a loadable kernel module.
> >>
> >> Dmitry Osipenko (3):
> >>   gpio: tegra: Use debugfs_create_devm_seqfile()
> >>   gpio: tegra: Clean up whitespaces in tegra_gpio_driver
> >>   gpio: tegra: Support building driver as a loadable module
> >
> > As these three patches clearly make the kernel look better after
> > than before:
> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> >
> > However when we are doing this I would strongly encourage you
> > to also make a patch implementing remove() so you can insmod
> > rmmod the module at runtime.
>
> The remove() is optional for drivers, it doesn't prevent the rmmod.

Aha you mean all resources are managed (devm_*) so that
rmmod/insmod works fine with this driver?

OK then! :) the work is finished.

Yours,
Linus Walleij