Re: [PATCH] pinctrl: pinmux: add function selector to pinmux-functions

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Sun, Jan 24, 2021 at 10:21 PM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote:
> On Sun, Jan 24, 2021 at 10:01:49PM +0200, Andy Shevchenko wrote:
> > On Sat, Jan 23, 2021 at 10:44 PM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote:

> > > Patch note:
> > > This may seem trivial but I found myself coming up with series of pipes
> > > in the shell just so I could see the function selector in line with the
> > > function names. At first, I thought I could just pipe to 'cat -n' but
> > > that counts at offset 1 instead of 0.
> >
> > SO advises [1] to use `nl -v0` instead.
>
> Neat! That is a nice utility to remember. I feel bad now for piping to
> perl to solve the problem :)
>
> I know this is rather trivial change but I think does seem to make sense
> to print the function selector along with the function name.

I'm not against the patch. Simply learning shell together :)

> > > The only downside I can see to
> > > this patch would be if someone is depending on the existing format but
> > > I don't believe that is a concern for debugfs, right?
> >
> > Debugfs is not an ABI.
> >
> > [1]: https://superuser.com/a/1433656/415970


-- 
With Best Regards,
Andy Shevchenko