Re: [PATCH 06/15] dt_bindings: regulator: Add ROHM BD71815 PMIC regulators

["Vaittinen, Matti" <Matti.Vaittinen@xxxxxxxxxxxxxxxxx>]

On Wed, 2021-01-13 at 07:53 -0600, Rob Herring wrote:
> On Tue, Jan 12, 2021 at 08:10:14AM +0200, Matti Vaittinen wrote:
> > On Mon, 2021-01-11 at 13:09 -0600, Rob Herring wrote:
> > > On Fri, Jan 08, 2021 at 03:36:38PM +0200, Matti Vaittinen wrote:
> > > > Add binding documentation for regulators on ROHM BD71815 PMIC.
> > > > 5 bucks, 7 LDOs and a boost for LED.
> > > > 
> > > > Signed-off-by: Matti Vaittinen <
> > > > matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > > > ---
> > > >  .../regulator/rohm,bd71815-regulator.yaml     | 104
> > > > ++++++++++++++++++
> > > >  1 file changed, 104 insertions(+)
> > > >  create mode 100644
> > > > Documentation/devicetree/bindings/regulator/rohm,bd71815-
> > > > regulator.yaml
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/regulator/rohm,bd71815-
> > > > regulator.yaml
> > > > b/Documentation/devicetree/bindings/regulator/rohm,bd71815-
> > > > regulator.yaml
> > > > new file mode 100644
> > > > index 000000000000..2aa21603698c
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/regulator/rohm,bd71815-
> > > > regulator.yaml
> > > > @@ -0,0 +1,104 @@
> > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: 
> > > > http://devicetree.org/schemas/regulator/rohm,bd71815-regulator.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: ROHM BD71815 Power Management Integrated Circuit
> > > > regulators
> > > > +
> > > > +maintainers:
> > > > +  - Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > > > +
> > > > +description: |
> > > > +  This module is part of the ROHM BD718215 MFD device. For
> > > > more
> > > > details
> > > > +  see Documentation/devicetree/bindings/mfd/rohm,bd71815-
> > > > pmic.yaml.
> > > > +
> > > > +  The regulator controller is represented as a sub-node of the
> > > > PMIC node
> > > > +  on the device tree.
> > > > +
> > > > +  The valid names for BD71815 regulator nodes are
> > > > +  buck1, buck2, buck3, buck4, buck5,
> > > > +  ldo1, ldo2, ldo3, ldo4, ldo5,
> > > > +  ldodvref, ldolpsr, wled
> > > 
> > > No schema for the last 3?
> > 
> > Thanks Rob. I'm unsure what I have been thinking of :( I'll fix
> > this
> > for next version.
> > 
> > > > +
> > > > +patternProperties:
> > > > +  "^(ldo|buck)[1-5]$":
> > > > +    type: object
> > > > +    description:
> > > > +      Properties for single LDO/BUCK regulator.
> > > > +    $ref: regulator.yaml#
> > > > +
> > > > +    properties:
> > > > +      regulator-name:
> > > > +        pattern: "^(ldo|buck)[1-5]$"
> > > > +        description:
> > > > +          should be "ldo1", ..., "ldo5" and "buck1", ...,
> > > > "buck5"
> > > > +
> > > > +      rohm,vsel-gpios:
> > > > +        description:
> > > > +          GPIO used to control ldo4 state (when ldo4 is
> > > > controlled
> > > > by GPIO).
> > > > +
> > > > +      rohm,dvs-run-voltage:
> > > 
> > > These should have a unit suffix.
> > 
> > I know but these are existing properties. I'd like to re-use them
> > as
> > they have exported parser helpers - and I am unsure what kind of
> > breakages changing them would cause. (The BD71837/BD71847 which
> > introduced these properties are one of the PMICs which are pretty
> > widely used.)
> 
> Okay. Hopefully I remember next time I see this...

Actually, I think I can add support for rohm,dvs-run-microvolt and
fellows to these same helpers so new devices can use appropriately
named properties. That would mean there is duplicate properties for
same purpose - but maybe it allows us to eventually deprecate the old
ones... Which of these options would you prefer?

> 
> Rob