Re: [PATCH] gpio: gpiolib: remove shadowed variable

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Tue, Jan 5, 2021 at 12:00 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> After refactoring, we had two variables for the same thing. Remove the
> second declaration, one is enough here. Found by cppcheck.
>
> drivers/gpio/gpiolib.c:2551:17: warning: Local variable 'ret' shadows outer variable [shadowVariable]
>
> Fixes: d377f56f34f5 ("gpio: gpiolib: Normalize return code variable name")
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds