On Tue, Dec 15, 2020 at 12:37 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Mon, Dec 14, 2020 at 5:57 PM Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: > > On Mon, Dec 14, 2020 at 10:11:23AM +0100, Linus Walleij wrote: > > > On Mon, Dec 14, 2020 at 9:24 AM Luo Jiaxing <luojiaxing@xxxxxxxxxx> wrote: > > > > > > > This GPIO driver is for HiSilicon's ARM SoC. > > > > > > Patch applied, any further issues can certainly be fixed in-tree. > > > > I just sent two :-) > > Thanks Andy! > > Actually I kind like this in a way because then you also get some > credit for the heavy review work that you do on new drivers and > so often go uncredited. You are welcome! > I'm sometimes tempted to even add "Co-developed-by" for the > vast improvements you bring up. (Like on my YAS530 driver.) With the CdB tag the SoB must go (per documentation) and I can't give you the latter one for your contribution for obvious reasons. OTOH feel free to give credit in a free form in the cover letter / commit message if you think it's good to have. -- With Best Regards, Andy Shevchenko