Re: [PATCH] gpiolib: Disallow identical line names in the same chip

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Linus,

On Mon, Dec 14, 2020 at 11:40 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Mon, Dec 14, 2020 at 10:29 AM Johan Hovold <johan@xxxxxxxxxx> wrote:
> > As I mentioned earlier, the not-globally unique warning only makes sense
> > for cases where all names comes from something like devicetree, and we
> > shouldn't warn if we plug in two identical USB devices that provide
> > default line names.
> >
> > Not sure it's even warranted to warn even if those default names collide
> > with the names provided in devicetree. Perhaps best to just drop the
> > flat-namespace assumption entirely and make sure gpiolib and the
> > userspace library can handle that.
>
> You're right. (As usual.)
>
> I dropped the global collision warning when applying.

Commit 2cd64ae98f352873 ("gpiolib: Disallow identical line
names in the same chip") still mentions the global collision warning
in the comments:

    Allow names to not be globally unique but warn about it

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds