Re: [PATCH] drivers: gpio: add virtio-gpio guest driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 2020-12-04 09:28, schrieb Enrico Weigelt, metux IT consult:
On 03.12.20 23:35, Michael Walle wrote:
Am 2020-12-03 20:00, schrieb Enrico Weigelt, metux IT consult:
On 02.12.20 15:15, Bartosz Golaszewski wrote:
+               bufwalk = name_buffer;
+
+               while (idx < priv->num_gpios &&
+                      bufwalk < (name_buffer+cf.names_size)) {
+                       gpio_names[idx] = (strlen(bufwalk) ? bufwalk
: NULL);
+                       bufwalk += strlen(bufwalk)+1;
+                       idx++;


Something's wrong with indentation here.

i dont think so: the "bufwalk ..." line belongs to the while expression and is right under the "idx", as it should be. I didn't want to break up
at the "<" operator. shall i do this instead ?

Or don't break the lines at all. Both lines don't add up to more than
100 chars,
right?

IIRC checkpatch complains at 80 chars. Has that been changed ?

yes,
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144

-michael



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux