Re: [PATCH v7 07/18] gpiolib: Introduce gpio_set_debounce_timeout() for internal use

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Thu, Nov 12, 2020 at 1:12 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> On 11/12/20 12:06 PM, Mika Westerberg wrote:
> > On Thu, Nov 12, 2020 at 12:19:37PM +0200, Andy Shevchenko wrote:
> >> On Thu, Nov 12, 2020 at 10:17 AM Mika Westerberg
> >> <mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> >>> On Thu, Nov 12, 2020 at 12:19:57AM +0200, Andy Shevchenko wrote:
> >>
> >> ...
> >>
> >>>> +int gpio_set_debounce_timeout(struct gpio_desc *desc, unsigned int debounce)
> >>
> >>> Sorry for commenting this late but I realized we have
> >>> gpiod_set_debounce() already. At least this new function should follow
> >>> the naming (gpiod as it takes descriptior):
> >>>
> >>> int gpiod_set_debounce_optional(struct gpio_desc *desc, unsigned int debounce);
> >>
> >> Unfortunately it will be inconsistent with the naming schema. I
> >> explained the choice of name in the cover letter. I will elaborate a
> >> bit there.
> >
> > OK, It seems that I was not CC'd cover letter of the last two versions,
> > or it got dropped somewhere.
>
> Yes I did not get the cover-letter either, I was actually wondering if there
> was one...

Oops, I dropped --cc because of your Rb tags (and I have added Cc when
there is no tag), but I forgot to add Cc to the cover letter.

Here we are [1].

[1]: https://lore.kernel.org/linux-gpio/20201111222008.39993-1-andriy.shevchenko@xxxxxxxxxxxxxxx/


-- 
With Best Regards,
Andy Shevchenko