Re: [PATCH v7 07/18] gpiolib: Introduce gpio_set_debounce_timeout() for internal use

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 12, 2020 at 12:19:37PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 12, 2020 at 10:17 AM Mika Westerberg
> <mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> > On Thu, Nov 12, 2020 at 12:19:57AM +0200, Andy Shevchenko wrote:
> 
> ...
> 
> > > +int gpio_set_debounce_timeout(struct gpio_desc *desc, unsigned int debounce)
> 
> > Sorry for commenting this late but I realized we have
> > gpiod_set_debounce() already. At least this new function should follow
> > the naming (gpiod as it takes descriptior):
> >
> > int gpiod_set_debounce_optional(struct gpio_desc *desc, unsigned int debounce);
> 
> Unfortunately it will be inconsistent with the naming schema. I
> explained the choice of name in the cover letter. I will elaborate a
> bit there.

OK, It seems that I was not CC'd cover letter of the last two versions,
or it got dropped somewhere.



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux