Re: [PATCH v2 3/3] gpiolib: of: Use named item for enum gpiod_flags variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 05, 2020 at 10:05:52AM +0100, Linus Walleij wrote:
> On Mon, Oct 26, 2020 at 3:43 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Mon, Oct 26, 2020 at 4:40 PM Bartosz Golaszewski
> > <bgolaszewski@xxxxxxxxxxxx> wrote:
> > >
> > > On Thu, Oct 22, 2020 at 6:58 PM Andy Shevchenko
> > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > >
> > > > Use named item instead of plain integer for enum gpiod_flags
> > > > to make it clear that even 0 has its own meaning.
> >
> > > This patch doesn't seem to depend on the others in this series so I
> > > applied it to my tree. Let me know if that's not the case. I'll let
> > > you take the ACPI patches.
> >
> > It's fine, thanks! I have just sent an additional message to elaborate
> > my vision, but again, the approach for this patch you chose is just
> > fine.
> 
> I might have lost track of the state of this patch set and mix it
> up conceptually with some other patch sets so bear with me if
> there are mistakes.

Consider to review / Ack [1]. I hope I addressed all / most of the comments.

> I see that Bartosz applied this one patch at least.

Yes.

[1]: https://lore.kernel.org/linux-gpio/20201102191722.81502-1-andriy.shevchenko@xxxxxxxxxxxxxxx/

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux