Re: [PATCH v2 3/3] gpiolib: of: Use named item for enum gpiod_flags variable

[Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>]

On Thu, Oct 22, 2020 at 6:58 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> Use named item instead of plain integer for enum gpiod_flags
> to make it clear that even 0 has its own meaning.
>
> Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> v2: no changes
>  drivers/gpio/gpiolib-of.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 2f895a2b8411..892a513b7a64 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -593,7 +593,7 @@ static struct gpio_desc *of_parse_own_gpio(struct device_node *np,
>
>         xlate_flags = 0;
>         *lflags = GPIO_LOOKUP_FLAGS_DEFAULT;
> -       *dflags = 0;
> +       *dflags = GPIOD_ASIS;
>
>         ret = of_property_read_u32(chip_np, "#gpio-cells", &tmp);
>         if (ret)
> --
> 2.28.0
>

This patch doesn't seem to depend on the others in this series so I
applied it to my tree. Let me know if that's not the case. I'll let
you take the ACPI patches.

Bartosz