On Wed, 2020-11-04 at 13:06 -0600, Rob Herring wrote: > On Wed, 04 Nov 2020 11:39:35 +0100, Nicolas Saenz Julienne wrote: > > The PWM bus controlling the fan in RPi's official PoE hat can only be > > controlled by the board's co-processor. > > > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > > > --- > > > > Changes since v1: > > - Update bindings to use 2 #pwm-cells > > > > .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 20 +++++++++++++++++++ > > .../pwm/raspberrypi,firmware-pwm.h | 13 ++++++++++++ > > 2 files changed, 33 insertions(+) > > create mode 100644 include/dt-bindings/pwm/raspberrypi,firmware-pwm.h > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: pwm:#pwm-cells:0:0: 2 was expected Yes I forgot to update the example... Regards, Nicolas
Attachment:
signature.asc
Description: This is a digitally signed message part
