Re: [PATCH v1 2/2] pinctrl: intel: Set default bias in case no particular value given

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Wed, Oct 14, 2020 at 01:46:38PM +0300, Andy Shevchenko wrote:
> When GPIO library asks pin control to set the bias, it doesn't pass
> any value of it and argument is considered boolean (and this is true
> for ACPI GpioIo() / GpioInt() resources, by the way). Thus, individual
> drivers must behave well, when they got the resistance value of 1 Ohm,
> i.e. transforming it to sane default.
> 
> In case of Intel pin control hardware the 5 kOhm sounds plausible
> because on one hand it's a minimum of resistors present in all
> hardware generations and at the same time it's high enough to minimize
> leakage current (will be only 200 uA with the above choice).
> 
> Fixes: e57725eabf87 ("pinctrl: intel: Add support for hardware debouncer")
> Reported-by: Jamie McClymont <jamie@xxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>