Re: [PATCH v2] gpiolib: Switch to use compat_need_64bit_alignment_fixup() helper

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Mon, Oct 12, 2020 at 09:07:41PM +0800, Kent Gibson wrote:
> On Thu, Oct 08, 2020 at 04:41:05PM +0300, Andy Shevchenko wrote:
> > The new compat_need_64bit_alignment_fixup() helper allows to avoid
> > ugly ifdeffery in IOCTL compatible code. Use it in GPIO cdev code.

> I'd re-arrange that checkin comment to
> 
> "Use the new compat_need_64bit_alignment_fixup() helper to avoid
> ugly ifdeffery in IOCTL compatibility code."

OK!

> but otherwise all good.
> 
> +1 on the deuglification, and it still works too.
> 
> Tested-by: Kent Gibson <warthog618@xxxxxxxxx>

Thanks.

> > Depends-on: 527c412519eb ("compat: add a compat_need_64bit_alignment_fixup() helper")

> > Depends-on: cc7886d25bca ("compat: lift compat_s64 and compat_u64 to <asm-generic/compat.h>")

I'll also drop this one, since former is dependent on latter.

-- 
With Best Regards,
Andy Shevchenko