Re: [PATCH v2 1/2] pinctrl: mcp23s08: Use full chunk of memory for regmap configuration

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Mon, Oct 12, 2020 at 2:56 PM Martin Hundebøll <martin@xxxxxxxxxx> wrote:
>
> Hi Linus,
>
> You can add my
> Tested-by: Martin Hundebøll <martin@xxxxxxxxxx>

Thank you!
Linus, below more typo fixes, but I'm not going to send a new version
(until you explicitly require), so please take them into consideration
when applying.

> Thanks,
> Martin
>
> On 09/10/2020 20.08, Andy Shevchenko wrote:
> > It appears that simplification of mcp23s08_spi_regmap_init() made
> > a regression due to wrong size calculation for dev_kmemdup() call.

> > It mises the fact that config variable is already a pointer, thus

mises -> misses

> > the sizeof() calculation is wrong and only 4 or 8 bytes were copied.
> >
> > Fix the parameters to devm_kmemdup() to copy full chunk of memory.

copy full -> copy a full

> >
> > Fixes: 0874758ecb2b ("pinctrl: mcp23s08: Refactor mcp23s08_spi_regmap_init()")
> > Reported-by: Martin Hundebøll <martin@xxxxxxxxxx>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> > v2: fixed few typos in the commit message
> >   drivers/pinctrl/pinctrl-mcp23s08_spi.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/pinctrl-mcp23s08_spi.c b/drivers/pinctrl/pinctrl-mcp23s08_spi.c
> > index 1f47a661b0a7..7c72cffe1412 100644
> > --- a/drivers/pinctrl/pinctrl-mcp23s08_spi.c
> > +++ b/drivers/pinctrl/pinctrl-mcp23s08_spi.c
> > @@ -119,7 +119,7 @@ static int mcp23s08_spi_regmap_init(struct mcp23s08 *mcp, struct device *dev,
> >               return -EINVAL;
> >       }
> >
> > -     copy = devm_kmemdup(dev, &config, sizeof(config), GFP_KERNEL);
> > +     copy = devm_kmemdup(dev, config, sizeof(*config), GFP_KERNEL);
> >       if (!copy)
> >               return -ENOMEM;
> >
> >



-- 
With Best Regards,
Andy Shevchenko