Re: Re: [PATCH v1 1/9] pinctrl: mcp23s08: Get rid of legacy platform data

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Fri, Oct 09, 2020 at 05:02:36PM +0300, Andy Shevchenko wrote:
> On Fri, Oct 09, 2020 at 11:15:57AM +0200, Martin Hundebøll wrote:
> > On 16/04/2020 12.35, Linus Walleij wrote:
> > > On Tue, Apr 7, 2020 at 7:38 PM Andy Shevchenko
> > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> > I tried to bisect, but some of the commits failed to compile:
> > 
> > > drivers/pinctrl/pinctrl-mcp23s08.c:959:39: error: 'mcp23s08_spi_of_match'
> > undeclared (first use in this function); did you mean
> > 'mcp23s08_i2c_of_match'?
> > 
> > >  959 |  match = of_match_device(of_match_ptr(mcp23s08_spi_of_match),
> > &spi->dev);
> 
> At which patch this happens?
> 
> I compiled them individually but it might be slipped during rebase in between
> of versions of the patch series.

JFYI: I have got Linux next and reverted all patches down to the one before my
series you complained about. Then I have compiled and reverted one-by-one.
Here is the log:

$ git reset --hard HEAD~1
HEAD is now at f018c29d2f05 Revert "pinctrl: mcp23s08: Deduplicate IRQ chip filling"
$ git reset --hard HEAD~1
HEAD is now at fd9a21af4720 Revert "pinctrl: mcp23s08: Consolidate SPI and I²C code"
$ git reset --hard HEAD~1
HEAD is now at efd1e6d2cdfe Revert "pinctrl: mcp23s08: Drop unused parameter in mcp23s08_probe_one()"
$ git reset --hard HEAD~1
HEAD is now at c0a36f9d6641 Revert "pinctrl: mcp23s08: Refactor mcp23s08_spi_regmap_init()"
$ git reset --hard HEAD~1
HEAD is now at b7cbbb8df01c Revert "pinctrl: mcp23s08: Propagate error code from device_property_read_u32()"
$ git reset --hard HEAD~1
HEAD is now at 819740665f29 Revert "pinctrl: mcp23s08: Make use of device properties"
$ git reset --hard HEAD~1
HEAD is now at 4a183ba59936 Revert "pinctrl: mcp23s08: Use for_each_set_bit() and hweight_long()"
$ git reset --hard HEAD~1
HEAD is now at 229eb0d949ee Revert "pinctrl: mcp23s08: Split to three parts: core, I²C, SPI"
$ git reset --hard HEAD~1
HEAD is now at 3d5db262b4cc Revert "pinctrl: mcp23s08: add module license"
$ git reset --hard HEAD~1
HEAD is now at 67d3e3edbab4 Revert "pinctrl: mcp23s08: Split to three parts: fix ptr_ret.cocci warnings"
$ git reset --hard HEAD~1
HEAD is now at d916cd9888b3 Revert "pinctrl: mcp23s08: Use irqchip template"
$ git reset --hard HEAD~1
HEAD is now at f0c94c7500ab Revert "pinctrl: mcp23s08: Improve error messaging in ->probe()"
$ git reset --hard HEAD~1
HEAD is now at 23593741ba99 Revert "pinctrl: mcp23s08: Fix mcp23x17_regmap initialiser"
$ git reset --hard HEAD~1
HEAD is now at 2f5dc6077839 Revert "pinctrl: mcp23s08: Fix mcp23x17 precious range"
$ git reset --hard HEAD~1
HEAD is now at ...

Every single patch is compiled perfectly. Are you sure you have clean tree?

Also I spent a bit of time to look again in the what may be possible of
breakage and found nothing alarming. Please, give more details about the issue.

-- 
With Best Regards,
Andy Shevchenko