Hi Andy,
On 16/04/2020 12.35, Linus Walleij wrote:
On Tue, Apr 7, 2020 at 7:38 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
Platform data is a legacy interface to supply device properties
to the driver. In this case we even don't have in-kernel users
for it. Just remove it for good.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
All 9 patches applied.
This series caused probing of my PiFace2 to fail:
> [ 1.019604] mcp23s08: probe of spi0.0 failed with error -22
I tried to bisect, but some of the commits failed to compile:
> drivers/pinctrl/pinctrl-mcp23s08.c:959:39: error:
'mcp23s08_spi_of_match' undeclared (first use in this function); did you
mean 'mcp23s08_i2c_of_match'?
> 959 | match = of_match_device(of_match_ptr(mcp23s08_spi_of_match),
&spi->dev);
However, bisecting did narrow it down to a few commits:
> * 1ac30db20be2 - (refs/bisect/bad) pinctrl: mcp23s08: Make use of
device properties (6 months ago) <Andy Shevchenko>
> * 88af89b52a1b -
(refs/bisect/skip-88af89b52a1b7493f1e5ec165856b4c6767cf654) pinctrl:
mcp23s08: Propagate error code from device_property_read_u32() (6 months
ago) <Andy Shevchenko>
> * 0874758ecb2b -
(refs/bisect/skip-0874758ecb2b3faa200a86dda45dbc29335f883e) pinctrl:
mcp23s08: Refactor mcp23s08_spi_regmap_init() (6 months ago) <Andy
Shevchenko>
> * 0521701c8d10 -
(refs/bisect/skip-0521701c8d10f832a401cc7ebfa92bb73782d792) pinctrl:
mcp23s08: Drop unused parameter in mcp23s08_probe_one() (6 months ago)
<Andy Shevchenko>
> * d3da29b628a8 -
(refs/bisect/skip-d3da29b628a86777d25c741c44b8af35f10020a0) pinctrl:
mcp23s08: Consolidate SPI and I²C code (6 months ago) <Andy Shevchenko>
> * 84d02e785d34 -
(refs/bisect/good-84d02e785d34be9363a825d696cca1f07fac2634) pinctrl:
mcp23s08: Deduplicate IRQ chip filling (6 months ago) <Andy Shevchenko>
I'm using the rpi3 device tree (broadcom/bcm2837-rpi-3-b.dtb) overlayed
with a configuration for the mcp23s08:
/dts-v1/;
/plugin/;
/ {
fragment@0 {
target-path = "/soc/spi@7e204000";
__overlay__ {
pinctrl-names = "default";
pinctrl-0 = <&spi0_gpio7>;
#address-cells = <1>;
#size-cells = <0>;
status = "okay";
gpio@0 {
compatible = "microchip,mcp23s17";
reg = <0>;
gpio-controller;
#gpio-cells = <2>;
microchip,spi-present-mask = <0x01>;
spi-max-frequency = <1000000>;
};
};
};
};
I looked around the code a bit, and tried to compare it with v5.7, but
didn't see any obvious candidates.
// Martin
