Re: [PATCH v2 1/2] gpio/aspeed-sgpio: enable access to all 80 input & output sgpios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 16, 2020 at 6:51 AM Joel Stanley <joel@xxxxxxxxx> wrote:
>
> Hi GPIO maintainers,
>
> On Fri, 11 Sep 2020 at 02:20, Joel Stanley <joel@xxxxxxxxx> wrote:
> >
> > On Fri, 11 Sep 2020 at 02:11, Jeremy Kerr <jk@xxxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > Currently, the aspeed-sgpio driver exposes up to 80 GPIO lines,
> > > corresponding to the 80 status bits available in hardware. Each of these
> > > lines can be configured as either an input or an output.
> > >
> > > However, each of these GPIOs is actually an input *and* an output; we
> > > actually have 80 inputs plus 80 outputs.
> > >
> > > This change expands the maximum number of GPIOs to 160; the lower half
> > > of this range are the input-only GPIOs, the upper half are the outputs.
> > > We fix the GPIO directions to correspond to this mapping.
> > >
> > > This also fixes a bug when setting GPIOs - we were reading from the
> > > input register, making it impossible to set more than one output GPIO.
> > >
> > > Signed-off-by: Jeremy Kerr <jk@xxxxxxxxxxxxxxxxxxxx>
> > > Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
> >
> > Reviewed-by: Joel Stanley <joel@xxxxxxxxx>
>
> This series is good to go in for 5.10:
>

Hi Joel,

I don't have this in my inbox. Did you copy me on this series?

Bartosz



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux