Re: [libgpiod] [PATCH 0/5] Documentation improvements

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Tue, Aug 11, 2020 at 8:24 PM Alexander Stein
<alexander.stein@xxxxxxxxxxx> wrote:
>
> Am Dienstag, 11. August 2020, 03:39:50 CEST schrieb Kent Gibson:
> > On Mon, Aug 10, 2020 at 06:49:21PM +0200, Bartosz Golaszewski wrote:
> > > On Sat, Aug 8, 2020 at 12:06 PM Alexander Stein
> > > <alexander.stein@xxxxxxxxxxx> wrote:
> > > >
> > > > Hey,
> > > > this changeset improves the document generation by reducing warnings
> > > > as well as supporting building doc out of tree now.
> > > >
> > > > Alexander Stein (5):
> > > >   doc: Fix doxygen warnings
> > > >   doc: Use autotoolized Doxyfile
> > > >   doc: Fix doxygen warning
> > > >   doc: Remove obsolete PERL_PATH
> > > >   doc: Add @file to headers
> > > >
> > > >  .gitignore              |  1 +
> > > >  Doxyfile => Doxyfile.in |  8 ++++----
> > > >  Makefile.am             |  4 +---
> > > >  bindings/cxx/gpiod.hpp  |  6 +++++-
> > > >  configure.ac            |  1 +
> > > >  include/gpiod.h         | 30 +++++++++++++++++-------------
> > > >  6 files changed, 29 insertions(+), 21 deletions(-)
> > > >  rename Doxyfile => Doxyfile.in (93%)
> > > >
> > > > --
> > > > 2.28.0
> > > >
> > >
> > > Thanks for sending those! I guess I don't see any of the warnings you
> > > mention because doxygen on my laptop is too old (1.8.13)?
> > >
> >
> > For reference, I get some of the warnings addressed with doxygen 1.8.17
> > in my setup.
> > I don't get the a4wide (patch 3) so that might be new in 1.8.18, or
> > otherwise dependent on setup??
> >
> > Either way, it would be useful for the patch to mention what version
> > of doxygen is being targetted so everyone is on the same page.
>
> Yes, I'm on 1.8.18, current release for archlinux. You are right, I should
> have mentioned it in the patch though, sorry aobut that.
>

No worries, I'll add this to the commit message when applying.

Bartosz