Re: [PATCH v2] gpio: omap: handle pin config bias flags

[Drew Fustini <drew@xxxxxxxxxxxxxxx>]

On Fri, Jul 17, 2020 at 08:56:45PM +0200, Drew Fustini wrote:
> On Fri, Jul 17, 2020, 17:15 Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> wrote:
> 
> > On Thu, Jul 16, 2020 at 12:38 AM Drew Fustini <drew@xxxxxxxxxxxxxxx>
> > wrote:
> > >
> > > Modify omap_gpio_set_config() to handle pin config bias flags by calling
> > > gpiochip_generic_config().
> > >
> > > The pin group for the gpio line must have the corresponding pinconf
> > > properties:
> > >
> > > PIN_CONFIG_BIAS_PULL_UP requires "pinctrl-single,bias-pullup"
> > > PIN_CONFIG_BIAS_PULL_DOWN requires "pinctrl-single,bias-pulldown"
> > >
> > > This is necessary for pcs_pinconf_set() to find the requested bias
> > > parameter in the PIN_MAP_TYPE_CONFIGS_GROUP pinctrl map.
> >
> > ...
> >
> > > +       if ((pinconf_to_config_param(config) == PIN_CONFIG_BIAS_DISABLE)
> > ||
> > > +           (pinconf_to_config_param(config) == PIN_CONFIG_BIAS_PULL_UP)
> > ||
> > > +           (pinconf_to_config_param(config) ==
> > PIN_CONFIG_BIAS_PULL_DOWN))
> > > +       {
> > > +               ret = gpiochip_generic_config(chip, offset, config);
> > > +       }
> > > +       else if (pinconf_to_config_param(config) ==
> > PIN_CONFIG_INPUT_DEBOUNCE)
> > > +       {
> > > +               debounce = pinconf_to_config_argument(config);
> > > +               ret = omap_gpio_debounce(chip, offset, debounce);
> > > +       }
> >
> > It's a rather strange indentation of the curly braces. Don't you run
> > checkpatch?
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
> >
> 
> Thanks for pointing that out.  I should have caught that.
> 
> Linus - I submitted a v2 with the braces fixed.  Please let me know if I
> should send a patch just for the braces on top of what is already in
> for-next.
> 
> Thanks,
> Drew

Sorry for the noise.  I failed to realize that I had already sent v2
(regarding the handling of the return value).  I have now submitted v3
patch [0] to fix the braces formatting that Andy pointed out.

thanks,
drew

[0] https://lore.kernel.org/linux-omap/20200717194043.1774643-1-drew@xxxxxxxxxxxxxxx/