Re: [PATCH v2] gpio: omap: handle pin config bias flags

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Thu, Jul 16, 2020 at 12:38 AM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote:
>
> Modify omap_gpio_set_config() to handle pin config bias flags by calling
> gpiochip_generic_config().
>
> The pin group for the gpio line must have the corresponding pinconf
> properties:
>
> PIN_CONFIG_BIAS_PULL_UP requires "pinctrl-single,bias-pullup"
> PIN_CONFIG_BIAS_PULL_DOWN requires "pinctrl-single,bias-pulldown"
>
> This is necessary for pcs_pinconf_set() to find the requested bias
> parameter in the PIN_MAP_TYPE_CONFIGS_GROUP pinctrl map.

...

> +       if ((pinconf_to_config_param(config) == PIN_CONFIG_BIAS_DISABLE) ||
> +           (pinconf_to_config_param(config) == PIN_CONFIG_BIAS_PULL_UP) ||
> +           (pinconf_to_config_param(config) == PIN_CONFIG_BIAS_PULL_DOWN))
> +       {
> +               ret = gpiochip_generic_config(chip, offset, config);
> +       }
> +       else if (pinconf_to_config_param(config) == PIN_CONFIG_INPUT_DEBOUNCE)
> +       {
> +               debounce = pinconf_to_config_argument(config);
> +               ret = omap_gpio_debounce(chip, offset, debounce);
> +       }

It's a rather strange indentation of the curly braces. Don't you run checkpatch?

-- 
With Best Regards,
Andy Shevchenko