On Mon, May 25, 2020 at 9:40 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: We already have two conditionals inside the outer one to check > if the command is GPIO_GET_LINEINFO_WATCH_IOCTL. I think it's > time to actually do what I have proposed in the first place, i.e. > to separate GPIO_GET_LINEINFO_WATCH_IOCTL from GPIO_GET_LINEINFO_IOCTL. > It's +13 LOCs, and surprisingly only +13 bytes of binary on x86_32, > but for the price of much better readability. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Patch applied, had to merge in v5.7-rc7 for it to apply but I guess that was expected, thanks! Yours, Linus Walleij