Re: [PATCH v1] gpiolib: Separate GPIO_GET_LINEINFO_WATCH_IOCTL conditional

[Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>]

pon., 25 maj 2020 o 21:40 Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> napisał(a):
>
> We already have two conditionals inside the outer one to check
> if the command is GPIO_GET_LINEINFO_WATCH_IOCTL. I think it's
> time to actually do what I have proposed in the first place, i.e.
> to separate GPIO_GET_LINEINFO_WATCH_IOCTL from GPIO_GET_LINEINFO_IOCTL.
> It's +13 LOCs, and surprisingly only +13 bytes of binary on x86_32,
> but for the price of much better readability.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---

Well... fair enough.

Acked-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>