While playing with audio output on Meson8b I found out that the vendor kernel uses a custom version of the GPIO_PULL_UP flag. I suspect that we will need this for audio support on Meson8b and/or Meson8m2 but I don't see it hurt other platforms. Also while comparing the register bits with the GPIO direction (of GPIOs exported to sysfs) I sometimes had a mismatch. This also wires up gpio_chip.get_direction to have sysfs and the actual registers in sync. Changes since v1 from [0]: - re-send as non-"RFC" because I only got one comment in the past week for patch #2. Jerome pointed out an alternative way to GPIO_PULL_UP and GPIO_PULL_DOWN. However, this doesn't invalidate the patch, it just means that there are two ways to achieve the same goal. [0] https://patchwork.kernel.org/cover/11484185/ Martin Blumenstingl (2): pinctrl: meson: implement the gpio_chip get_direction callback pinctrl: meson: wire up the gpio_chip's set_config callback drivers/pinctrl/meson/pinctrl-meson.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) -- 2.26.1