On Thu, Mar 19, 2020 at 1:27 PM Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > From: Thierry Reding <treding@xxxxxxxxxx> > > Wake gpiochip_generic_request() call into the pinctrl helpers only if a > GPIO controller had any pin-ranges assigned to it. This allows a driver > to unconditionally use this helper if it supports multiple devices of > which only a subset have pin-ranges assigned to them. > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> Patch applied. We have some drivers like this: drivers/gpio/gpio-pl061.c: if (of_property_read_bool(dev->of_node, "gpio-ranges")) { pl061->gc.request = gpiochip_generic_request; pl061->gc.free = gpiochip_generic_free; } Should we just make a patch assigning these callbacks unconditionally as a follow-up? Yours, Linus Walleij