Re: [PATCH 1/9] gpio: Support GPIO controllers without pin-ranges

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 3/19/2020 5:57 PM, Thierry Reding wrote:
External email: Use caution opening links or attachments


From: Thierry Reding <treding@xxxxxxxxxx>

Wake gpiochip_generic_request() call into the pinctrl helpers only if a
GPIO controller had any pin-ranges assigned to it. This allows a driver
to unconditionally use this helper if it supports multiple devices of
which only a subset have pin-ranges assigned to them.

Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
---
  drivers/gpio/gpiolib.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index f31b1d46599e..12f3c339da78 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -2792,7 +2792,10 @@ static inline void gpiochip_irqchip_free_valid_mask(struct gpio_chip *gpiochip)
   */
  int gpiochip_generic_request(struct gpio_chip *chip, unsigned offset)
  {
-       return pinctrl_gpio_request(chip->gpiodev->base + offset);
+       if (!list_empty(&chip->gpiodev->pin_ranges))
+               return pinctrl_gpio_request(chip->gpiodev->base + offset);
+
+       return 0;
  }
  EXPORT_SYMBOL_GPL(gpiochip_generic_request);

--
2.24.1

Tested-by: Vidya Sagar <vidyas@xxxxxxxxxx>



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux